Update install_customizations to prevent warnings #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-f` to prevent `rm` throwing `remove write-protected regular file` warning.
afischer
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Force-remove the customisation folder in order to prevent
rmthrowingremove write-protected regular filewarning on Git objects under the.gitdirectory.Related Issue
N/A
Motivation and Context
When I was running the customisation script, I needed to manually say yes to all the
rm: remove write-protected regular file './custom/.git/objects/[...]'?warnings, so I think this should fix it.First PR here so please do correct me if I'm wrong about anything :)
Checklist
npm run lintand updated code style accordinglynpm run testpasses (it didn't pass even without my commit?)tests are updated and/or added to cover new code(no need for new tests I reckon?)relevant documentation is changed and/or added(does not affect documentation)