Add options.process caveat to readme #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizmagik
reviewed
Dec 30, 2021
README.md
Outdated
| @@ -330,6 +330,8 @@ function Page2() { | |||
| When `Page1` mounts, event with data `{page: 'Page1', event: 'pageview'}` will be dispatched. | |||
| When `Page2` mounts, nothing will be dispatched. | |||
|
|
|||
| _**Note:** The `options.process` function does not currently take single-page app (SPA) navigation into account. If the example above were implemented as an SPA, navigating back to `Page1`, with no page reload, would **not** cause `options.process` to fire a second time even if the `Page1` component remounts._ | |||
There was a problem hiding this comment.
Could we also mention the workaround and maybe link to the open issue for more reference/info?
There was a problem hiding this comment.
Added. Wasn't sure whether you wanted to link directly to the code sandbox.
tizmagik
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a note to document the bug reported in issue #189 until we can address.