Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

Dashboard tests #31

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Dashboard tests #31

merged 8 commits into from
Jun 2, 2020

Conversation

matthiasng
Copy link
Contributor

@matthiasng matthiasng commented Dec 23, 2019

This PR adds some test for the dashboard api.

Also includes some error handling improvements (missing error checks) and an invalid struct tag.

go test coverage before: 55.1% of statements
go test coverage after: 62.3% of statements

@mlclmj mlclmj added the size/L Denotes a PR that changes 100-499 lines label Jan 25, 2020
Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the test suite!

@tonglil tonglil merged commit 7d74f3b into nytm:master Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement size/L Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants