This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Concat request path to Base URL path. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request path. This is necessary when Grafana is running behind a reverse proxy that is doing path based routing.
|
Hi @apparentlymart |
|
Seems reasonable to me, @sl1pm4t! Thanks. This was forked for the Terraform provider in order to get some new functionality I needed to have Terraform manage data sources. At some point it would probably be a good idea to try to upstream all of these changes to raintank/grafana-api-golang-client, but unfortunately I don't have time to work on that right now. 😖 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the base URL includes a path component, don’t overwrite this with the
request path.
This is necessary when Grafana is running behind a reverse
proxy that is doing path based routing.