Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #1036

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Add CONTRIBUTING.md #1036

merged 1 commit into from
Mar 11, 2020

Conversation

pyeres
Copy link
Contributor

@pyeres pyeres commented Mar 11, 2020

This PR adds a CONTRIBUTING.md file, and includes "PR and review process guidelines".

Followup PRs are expected to add more guidelines around tests, documentation and style to this CONTRIBUTING.md file.

Copy link
Contributor

@pruksmhc pruksmhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyeres pyeres merged commit 9429aa2 into master Mar 11, 2020
@pyeres pyeres deleted the py/add_contributing_md branch March 11, 2020 16:07
phu-pmh pushed a commit that referenced this pull request Apr 17, 2020
@jeswan jeswan added the jiant-v1-legacy Relevant to versions <= v1.3.2 label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jiant-v1-legacy Relevant to versions <= v1.3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants