Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hidden_size in taskmodels #1148

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

zphang
Copy link
Collaborator

@zphang zphang commented Oct 13, 2020

Just for consistency - this should not affect the logic.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files         132      132           
  Lines        9652     9652           
=======================================
  Hits         5488     5488           
  Misses       4164     4164           
Impacted Files Coverage Δ
jiant/proj/main/modeling/model_setup.py 39.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58beb8f...2515072. Read the comment docs.

@jeswan jeswan merged commit 82ed396 into nyu-mll:master Oct 13, 2020
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants