Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arct #1151

Merged
merged 4 commits into from
Oct 14, 2020
Merged

arct #1151

merged 4 commits into from
Oct 14, 2020

Conversation

wh629
Copy link
Contributor

@wh629 wh629 commented Oct 13, 2020

I'm having issues running black. I spoke with Jason and am submitting the PR without black.

Changes tested with the attached .sh and .sbatch files. Achieved 82.3% dev accuracy and found 77% from https://arxiv.org/abs/1907.07355.

arct.zip

@pep8speaks
Copy link

pep8speaks commented Oct 13, 2020

Hello @wh629! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2020-10-14 17:50:34 UTC

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1151 into master will increase coverage by 0.06%.
The diff coverage is 72.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   56.85%   56.92%   +0.06%     
==========================================
  Files         132      133       +1     
  Lines        9652     9692      +40     
==========================================
+ Hits         5488     5517      +29     
- Misses       4164     4175      +11     
Impacted Files Coverage Δ
jiant/tasks/evaluate/core.py 37.15% <ø> (ø)
jiant/tasks/lib/arct.py 71.79% <71.79%> (ø)
jiant/tasks/retrieval.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392976c...1078012. Read the comment docs.

@jeswan jeswan merged commit b23c0f7 into nyu-mll:master Oct 14, 2020
@wh629
Copy link
Contributor Author

wh629 commented Oct 18, 2020

@habernal

leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
* arct

* black==19.10b0

* circleci test

Co-authored-by: jeswan <57466294+jeswan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants