Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation step to add task guide #1154

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

jeswan
Copy link
Collaborator

@jeswan jeswan commented Oct 14, 2020

This PR adds a step to the Add a task guide to document the added task in the supported tasks chart.

@wh629 Can you check I correctly documented arct? Also, please add the task in #1152 to the task chart.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files         133      133           
  Lines        9696     9696           
=======================================
  Hits         5518     5518           
  Misses       4178     4178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3387a3...7ae53ba. Read the comment docs.

@zphang
Copy link
Collaborator

zphang commented Oct 16, 2020

We should mention adding to the downloader as well. (Also, we need to clean up the organization of constants for task names for the downloader - they're in two very separate files currently.)

(Even more ambitiously, we could consider moving the downloading (+eval) logic to the task files themselves.)

@jeswan jeswan merged commit f4bca4e into master Oct 19, 2020
@jeswan jeswan deleted the js/documenation/add_task_doc_addition branch October 19, 2020 18:09
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants