Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust case for span prediction #1201

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Adjust case for span prediction #1201

merged 4 commits into from
Oct 19, 2020

Conversation

zphang
Copy link
Collaborator

@zphang zphang commented Oct 16, 2020

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1201 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
- Coverage   56.92%   56.91%   -0.01%     
==========================================
  Files         133      133              
  Lines        9692     9693       +1     
==========================================
  Hits         5517     5517              
- Misses       4175     4176       +1     
Impacted Files Coverage Δ
jiant/tasks/lib/templates/span_prediction.py 73.07% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6e8d4...d73fb34. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Oct 16, 2020

Hello @zphang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2020-10-17 00:31:44 UTC

@jeswan jeswan merged commit 5724fee into nyu-mll:master Oct 19, 2020
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
* adjust case for span prediction

* resolve_is_lower_case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants