Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcscript Task Property #1219

Merged
merged 8 commits into from
Oct 28, 2020
Merged

Mcscript Task Property #1219

merged 8 commits into from
Oct 28, 2020

Conversation

wh629
Copy link
Contributor

@wh629 wh629 commented Oct 27, 2020

Added back task property. This seems necessary for the tokenization.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1219 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   56.42%   56.41%   -0.01%     
==========================================
  Files         142      142              
  Lines       10230    10231       +1     
==========================================
  Hits         5772     5772              
- Misses       4458     4459       +1     
Impacted Files Coverage Δ
jiant/tasks/lib/mcscript.py 66.66% <50.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820f7de...18390dc. Read the comment docs.

@zphang zphang merged commit 76e2826 into nyu-mll:master Oct 28, 2020
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
* mcscript

* black

* add mcscript to documentation

* removed task property method

* added back task property

Co-authored-by: jeswan <57466294+jeswan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants