Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checkpoint save default behavior #1233

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

jeswan
Copy link
Collaborator

@jeswan jeswan commented Nov 12, 2020

This PR closes #1198 by deleting the checkpoint at the end of training by default.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1233 (3e753cf) into master (838cdd2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   56.56%   56.56%           
=======================================
  Files         147      147           
  Lines       10582    10582           
=======================================
  Hits         5986     5986           
  Misses       4596     4596           
Impacted Files Coverage Δ
jiant/proj/main/runscript.py 73.04% <100.00%> (ø)
jiant/proj/simple/runscript.py 80.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838cdd2...3e753cf. Read the comment docs.

@jeswan jeswan merged commit 59438ed into master Nov 12, 2020
@jeswan jeswan deleted the js/feature/change_checkpoint_save_default branch November 12, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make delete_checkpoint_if_done default behavior
2 participants