Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further fix for encoder_only #1242

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Further fix for encoder_only #1242

merged 1 commit into from
Dec 3, 2020

Conversation

zphang
Copy link
Collaborator

@zphang zphang commented Dec 2, 2020

Handles cases of loading across different taskmodel configurations

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #1242 (58fefbd) into master (1f66050) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1242   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files         147      147           
  Lines       10597    10597           
=======================================
  Hits         5987     5987           
  Misses       4610     4610           
Impacted Files Coverage Δ
jiant/proj/main/modeling/model_setup.py 36.68% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f66050...58fefbd. Read the comment docs.

Copy link
Collaborator

@jeswan jeswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeswan jeswan merged commit 50b0116 into nyu-mll:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants