Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test matrix #1308

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Add test matrix #1308

merged 7 commits into from
Apr 23, 2021

Conversation

jeswan
Copy link
Collaborator

@jeswan jeswan commented Apr 17, 2021

This PR adds a test matrix using the simple API. The goal of this test matrix is to test for regression across different tasks and models by:

  1. Checking that these models can successfully run
  2. Check that the performance of the models is the same when using the same seed, deterministic algorithms, and the same number of steps

@jeswan jeswan requested a review from zphang as a code owner April 17, 2021 02:38
@jeswan jeswan force-pushed the js/feature/add_test_matrix branch from e68fb0e to 6f3832f Compare April 17, 2021 02:41
@jeswan jeswan force-pushed the js/feature/add_test_matrix branch from 6f3832f to 06a62f0 Compare April 17, 2021 02:45
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #1308 (5905885) into master (ee65662) will not change coverage.
The diff coverage is n/a.

❗ Current head 5905885 differs from pull request most recent head e976d03. Consider uploading reports for the commit e976d03 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1308   +/-   ##
=======================================
  Coverage   48.46%   48.46%           
=======================================
  Files         163      163           
  Lines       11220    11220           
=======================================
  Hits         5438     5438           
  Misses       5782     5782           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee65662...e976d03. Read the comment docs.

@jeswan jeswan merged commit 4d0f6a9 into master Apr 23, 2021
@jeswan jeswan deleted the js/feature/add_test_matrix branch April 23, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants