fix roberta retokenization error #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaokunLiu
requested review from
iftenney,
pruksmhc,
sleepinyourhat and
W4ngatang
as code owners
|
Hello @HaokunLiu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 You can repair most issues by installing black and running: Comment last updated at 2020-01-08 01:46:27 UTC |
HaokunLiu
commented
Dec 28, 2019
| [[0], [1], [2], [3, 4], [5], [6, 7], [8], [9, 10, 11]], | ||
| [[0], [1, 2, 3], [4], [5], [6], [7], [8], [9, 10, 11], [12], [13], [14, 15]], | ||
| [[0], [1], [2], [3, 4], [5, 6], [7], [8], [9, 10, 11]], | ||
| [[0, 1], [2, 3], [4], [5], [6], [7], [8], [9, 10, 11], [12], [13], [14, 15]], |
There was a problem hiding this comment.
I wasn't computing this manually. I just printed out the output and skim over it.
I know this isn't how test cases are suppose to be made.
Me trying to save 5 minutes in the wrong place has wasted everyone else hours, there can't be enough apology for this.
|
@pruksmhc: Is there a reason this hasn't been merged? |
phu-pmh
pushed a commit
that referenced
this pull request
Apr 17, 2020
* fix roberta tokenization error * format Co-authored-by: Yada Pruksachatkun <yp913@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#934 #903 #904 #954
I'm very sorry about this bug. I thought I have fixed retokenization last time. But actually there was a typo left. I should have found this if I checked the test cases carefully.
This bug will cause the roberta retokenization to be less accurate, possibly negatively affect the performance on tasks that use realign index.