Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement search bar function for tasklist #11

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

zwinniez
Copy link
Collaborator

@zwinniez zwinniez commented Apr 30, 2024

Pull Request Template

Description

This pull request adds functionality to the task list search bar by searching up tasklist names.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Note:

Include the information the reviewers need to know.

@zwinniez zwinniez changed the title feat: working search bar for tasklist feat: implement search bar function for tasklist Apr 30, 2024
@zwinniez zwinniez requested a review from BowenGong2000 April 30, 2024 03:34
Copy link
Collaborator

@BowenGong2000 BowenGong2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good!

@BowenGong2000 BowenGong2000 merged commit a85cbb6 into main Apr 30, 2024
1 check passed
@Yanglin-Tao
Copy link
Collaborator

An issue occurred on my end, got a 404 error for script.js. Therefore both the search bar and dropdown don't seem to work properly if using the Flask init command. Could you please check the import statement and figure out what might go wrong?

@zwinniez
Copy link
Collaborator Author

@Yanglin-Tao thanks for bringing this up. Please refer to this for the PR fix: 4af9514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants