SPK/BPC domain function fix + Usability alterations for Nyx #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow initialization of Frames from their CCSDS names (e.g. Earth ICRF) - Allow serialization of Frame and Ellipsoid to/from Dhall - Rename `dump` and `load` to `dumps` and `loads` to follow the pickle/json/yaml nomenclature (not breaking, only deprecating their use so far)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
- Coverage 80.14% 79.94% -0.21%
==========================================
Files 71 72 +1
Lines 8653 8884 +231
==========================================
+ Hits 6935 7102 +167
- Misses 1718 1782 +64 ☔ View full report in Codecov by Sentry. |
|
This reduces the test coverage for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This mostly includes a few changes needed as I start using ANISE in Nyx. This PR also includes a bug fix for the
spk_domainandbpc_domainfunctions, which previously only returned the start and stop time of the first segment whose ID matched the desired ID.I'm trying to cram a few random additional changes in this PR as well.
Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
bpc_domaintest using the Earth high precision kernel.Documentation
This PR does not primarily deal with documentation changes.