Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DCM to Python #359

Merged
merged 9 commits into from
Dec 15, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

Export DCM to Python, including the method of Orbit that compute the RIC/VNC/RCN/Topocentric frames.

Architectural Changes

No change

New Features

No change

Improvements

  • Reduce workspace dependency definition and move dev deps to the correct location (should reduce build size)

Bug Fixes

No change

Testing and validation

  • Manually inspected that the order of the matrices matched between python and rust
  • Add DCM rebuilding tests in test_almanac.py

Documentation

This PR does not primarily deal with documentation changes.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (e5b8d3e) to head (1a69ee2).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
anise/src/math/rotation/dcm.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   80.59%   80.67%   +0.08%     
==========================================
  Files          77       78       +1     
  Lines       10166    10203      +37     
==========================================
+ Hits         8193     8231      +38     
+ Misses       1973     1972       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 8b8bb8d into master Dec 15, 2024
18 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 175-expose-rotation-parameters-to-python branch December 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant