Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 8.Unwrap error in #244
In the replay file,
from_format_str
takes "%" as format_str, thus causing the format returned byfrom_str
empty.hifitime/src/efmt/format.rs
Line 159 in 822c0a0
This results in the items in
parse
being empty, which causes an unwrap error. In my opinion, it should be classified as an UnknownFormat error since it's related to format.