Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todos #498

Merged
merged 43 commits into from
Jun 23, 2023
Merged

Todos #498

merged 43 commits into from
Jun 23, 2023

Conversation

abitofevrything
Copy link
Member

Description

Fixes most of the TODOs left behind during the rewrite process.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything
Add missing fields in GuildBuilder
1ac1230
@abitofevrything
Make repliedUser nullable in allowed_mentions
1e5bed3
@abitofevrything
Add missing activities field to PresenceBuilder
b6a9ad6
@abitofevrything
Add initial presence for gateway
e62ccfa
@abitofevrything
Handle adding an already existing member to a guild
1e4924b
@abitofevrything
TThrow an exception when a role is not found
8fe9c2a
@abitofevrything
Remove TODOs that won't be addressed
8b02b65
@abitofevrything
Fix guild tests
e0648ce
@abitofevrything
Complete thread member parsing test
971a275
@abitofevrything
Merge branch 'rewrite' of github.com:nyxx-discord/nyxx into todos
b929b67
@abitofevrything
Don't use package imports
2868aa4
@abitofevrything
Move integrations to their own manager
e75730b
@abitofevrything
Fix issues found by tests
e8914ce
@abitofevrything
Merge branch 'rewrite' of github.com:nyxx-discord/nyxx into todos
a38eacf
@abitofevrything
Add cache identifier to audit log manager
33d2a42
@abitofevrything
Add missing application role connection fieldsd & endpoints
312f7c2
@abitofevrything
Add globalName to users
97ec839
@abitofevrything
Add missing user endpoints
969d923
@abitofevrything
Add warning when force killing shard
3afc19c
@abitofevrything
Add warning when shard encounters error
bbfc619
@abitofevrything
Add exception when fetching an audit log entry that does not exist
930b2f2
@abitofevrything
Make HttpResponseError implement NyxxException
82c42eb
@abitofevrything
Remove completed TODO in Invite
a795a25
@abitofevrything
Add missing application field to Message
cb6527e
@abitofevrything
Merge branch 'rewrite' of github.com:nyxx-discord/nyxx into todos
5a7e102
@abitofevrything
Add missing fields to guild create event
5fd29d9
@abitofevrything
Add emoji to onboarding prompt
f2c7a7c
@abitofevrything
Add cache for VoiceStates
c883ce9
@abitofevrything
Add emojis to GuildPreview
d006303
@abitofevrything
Finish InviteCreateEvent
5199d68
@abitofevrything abitofevrything added this to the 6.0 milestone Jun 20, 2023
@abitofevrything abitofevrything self-assigned this Jun 20, 2023
Rapougnac
Rapougnac reviewed Jun 21, 2023
View reviewed changes
lib/src/api_options.dart Outdated Show resolved Hide resolved
lib/src/builders/invite.dart Outdated Show resolved Hide resolved
@abitofevrything abitofevrything marked this pull request as ready for review June 21, 2023 15:47
@abitofevrything abitofevrything mentioned this pull request Jun 21, 2023
Merged
8 tasks
@l7ssha l7ssha merged commit ad711f0 into rewrite Jun 23, 2023
@l7ssha l7ssha deleted the todos branch June 23, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rapougnac Rapougnac Rapougnac left review comments

@l7ssha l7ssha l7ssha approved these changes

Assignees

@abitofevrything abitofevrything

Labels
major-change
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@abitofevrything @l7ssha @Rapougnac