Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more precise emoji type in reaction events #533

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

abitofevrything
Copy link
Member

Description

Reaction events used to use PartialEmoji when the API returns an object that is always parseable to an Emoji. This PR changes these events to use the more precise type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added the enhancement New feature or request label Sep 10, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Sep 10, 2023
@abitofevrything abitofevrything self-assigned this Sep 10, 2023
@abitofevrything abitofevrything merged commit 9d79001 into rewrite Sep 10, 2023
7 checks passed
@abitofevrything abitofevrything deleted the feat/better-emoji-typing branch September 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants