Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various message component bug fixes #535

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Sep 12, 2023

Description

Fixes issue where the structure of a modal is created incorrectly. A draft PR as modal improvements seem to still be needed.

Edit: second commit fixes modal interaction.

Connected issues & other potential problems

Modals still cannot be recieved, as multiple exceptions are triggered.

Edit: above fixed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@jr1221
Copy link
Contributor Author

jr1221 commented Sep 13, 2023

I am just collecting various hacky fixes here. I do not intended to actually ask for this to be merged unless @abitofevrything wants me to, because I am sure he has better solutions to these problems.

@jr1221 jr1221 changed the title add label and action rows to models (correct formatting) Various message component bug fixes Sep 13, 2023
@l7ssha l7ssha added the bug Something isn't working label Sep 13, 2023
@l7ssha l7ssha added this to the 6.0 milestone Sep 13, 2023
Co-authored-by: Rapougnac <me@rapougnac.moe>
@jr1221 jr1221 marked this pull request as ready for review September 16, 2023 15:50
@jr1221
Copy link
Contributor Author

jr1221 commented Sep 16, 2023

Alright I think this is ready to go.

@jr1221
Copy link
Contributor Author

jr1221 commented Sep 17, 2023

Sorry if I messed up the review process very new to public repositories.

Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one small change for some future proofing.

Sorry if I messed up the review process very new to public repositories.

No worries, everything's fine! I just asked to review this last night, which is why it didn't get merged right after l7ssha'a approval.

lib/src/builders/interaction_response.dart Outdated Show resolved Hide resolved
@abitofevrything abitofevrything merged commit d130e4c into nyxx-discord:next Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants