-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various message component bug fixes #535
Conversation
I am just collecting various hacky fixes here. I do not intended to actually ask for this to be merged unless @abitofevrything wants me to, because I am sure he has better solutions to these problems. |
Co-authored-by: Rapougnac <me@rapougnac.moe>
Alright I think this is ready to go. |
Sorry if I messed up the review process very new to public repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one small change for some future proofing.
Sorry if I messed up the review process very new to public repositories.
No worries, everything's fine! I just asked to review this last night, which is why it didn't get merged right after l7ssha'a approval.
Description
Fixes issue where the structure of a modal is created incorrectly. A draft PR as modal improvements seem to still be needed.
Edit: second commit fixes modal interaction.
Connected issues & other potential problems
Modals still cannot be recieved, as multiple exceptions are triggered.
Edit: above fixed.
Type of change
Please delete options that are not relevant.
Checklist:
dart analyze
ormake analyze
and fixed all issuesdart format --set-exit-if-changed -l 160 ./lib
ormake format
and fixed all issues