Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify Cache.keys during iteration #698

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

abitofevrything
Copy link
Member

Description

Fix an issue where iterating over Cache.values threw a ConcurrentModificationError due to the underlying _mru list being updated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Oct 2, 2024
@abitofevrything abitofevrything added this to the 6.4.0 milestone Oct 2, 2024
@abitofevrything abitofevrything self-assigned this Oct 2, 2024
@abitofevrything abitofevrything marked this pull request as ready for review October 2, 2024 09:33
@abitofevrything abitofevrything merged commit 8b4b451 into dev Oct 2, 2024
7 checks passed
@abitofevrything abitofevrything deleted the bug/concurrent-cache-modification branch October 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Ready for deploy
Development

Successfully merging this pull request may close these issues.

3 participants