Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file/directory permissions after unpacking #222

Merged
merged 11 commits into from
Apr 15, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Apr 12, 2024

Description

  • fixed file/directory permissions overriden by the unpacker;
  • added the DEBUG definition for debug builds on POSIX systems.

Testing

@dnzbk Linux Debian 12 with NZBGet v23.1
@phnzb Ubuntu 22.04.4 LTS x86_64

@dnzbk dnzbk linked an issue Apr 12, 2024 that may be closed by this pull request
@dnzbk dnzbk requested review from phnzb and luckedea April 12, 2024 05:59
@dnzbk dnzbk merged commit f268896 into develop Apr 15, 2024
4 checks passed
@dnzbk dnzbk deleted the fix/permissions-after-unpack branch April 15, 2024 07:59
@Anuskuss
Copy link
Contributor

This gives me F666 and D777 instead of the normal F644 and D755. If the user doesn't use the UMask setting you should ideally either read the user's umask or just assume 022 (for security purposes). And you should probably always request 777 and let the umask do the rest.

@luckedea
Copy link
Member

@Anuskuss Thanks for the report, confirmed. Created an issue - #228 working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong permissions after unrar on some NZBs
4 participants