Feature/unit tests #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/unit-tests-ci
dnzbk
added
bug
phnzb
approved these changes
Nov 23, 2023
dnzbk
added a commit
that referenced
this pull request
Feb 9, 2024
nzbget-23.0
- Features:
- Extension Manager [#76](7348b19);
* The new nzbget extension system, which makes it easy to download/update/delete
extensions with backward compatibility with the old system;
* extensions [master list](https://github.com/nzbgetcom/nzbget-extensions/);
* changed:
- RPC request "configtemplates" - no longer returns script templates, but only the config template;
* added:
- new RPC requests:
- "loadextensions" - loads all extensions from {ScriptDIR} and returns an array of structures in JSON/XML formats;
- "updateextension" - downloads by url and name and installs the extension. Returns 'true' or error response in JSON/XML formats;
- "deleteextension" - deletes extension by name. Returns 'true' or error response in JSON/XML formats;
- "downloadextension" - downloads by url and installs the extension. Returns 'true' or error response in JSON/XML formats;
- "testextension" - tries to find the right executor program for the extension, e.g. Python.
Returns 'true' or error response in JSON/XML formats;
- "EXTENSION MANAGER" section in webui to download/delete/update extensions;
- Boost.Json library to work with JSON;
- more unit tests;
* refactored:
- replaced raw pointers with smart pointers and const refs where possible for memory safty reasons;
* removed:
- testdata_FILES from Makefile.am;
- EMail and Logger scripts;
- Docker support [#55](1913e33);
- Synology support (spk) [#72](3f8fd6d);
- QNAP support [#158](9676c77);
- aarch64 mipseb mipsel ppc6xx ppc500 architectures to linux build [#61](9599854) [#146](fcc104d);
- article read chunk size [#52](1aa42f2);
* Added ArticleReadChunkSize config option which allows to adjust
the buffer size for customization on different platforms, which can lead to increased performance;
- increased the number of default connections to 8 [#54](55eca4c);
- automatic search for a suitable interpreter on POSIX [#74](ec0756d);
- certificate verification levels [#150](5956a17);
* levels:
- None: NO certificate signing check, NO certificate hostname check;
- Minimal: certificate signing check, NO certificate hostname check;
- Strict: certificate signing check, certificate hostname check;
* tested on a mock nzbget NNTP nserv server with self-signed certificate and got expected results:
- "Strict" -> test failed;
- "Minimal" -> test failed;
- "None" -> test passed";
- Bug fixies:
- possible memory corruption [#148](16ab25d);
- For developers:
- fixed unit tests (Windows only for now) and started migration to CMake [#64](73e8c00);
* We are going to completely migrate to CMake as a more universal one for cross-platform development and drop autotools and MSBuild;
- using libxml2 on Windows and vcpkg package manager to install dependencies [#70](f8cb2bd);
* libxml2 library is now used on Windows to work with xml in the same way we already do on Linux and macOS;
* removed platform-dependent code for working with xml on Windows;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nntp and postprocessor tests do not pass. I'll look in more detail later.