Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ultrabot (ultrasonic sensorsh) #2

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

delijati
Copy link
Contributor

@delijati delijati commented May 3, 2014

Hi i've added my ultrasonic, different encoders version bot to the code. I rearange the code base and cleand it up (pep8).
I hope i find next week the time to add it to the o-botics site and some pictures ;)

@rowoflo
Copy link
Contributor

rowoflo commented May 3, 2014

This looks great! I merged your pull request. I was just sitting down to write something similar to incorporate the QuickBot v2 code. But I like how you have structured it.

I am going to make a new branch for the QuickBot v1 and not update that anymore. Then merge in the new code for QuickBot v2 into the master branch. That way people from the course with original QuickBot can still get to the original code. Do you think that is the best approach? Or I can just add a new class file in the "xbots" folder called "quickbot_v2.py"

I guess the repo name needs to be updated. Maybe xbot_bbb instead of quickbot_bbb.

@delijati
Copy link
Contributor Author

delijati commented May 4, 2014

Oh nice that was fast.

Yeah i would add the v2 version simply as an new py file as you proposed. In the run.py you can add than this:

RTYPES = ('quick', 'quickv2', 'ultra')
...
    if options.rtype == 'quickv2':
        import xbots.quickbot_v2
        qb = xbots.quickbot_v2.QuickBot(options.ip, options.rip)
        qb.run()
...

If we get more bot's in the future we can reconsider a renaming!?

rowoflo added a commit that referenced this pull request May 31, 2014
fixed pin assignments to match course materials
@delijati
Copy link
Contributor Author

Some more changes to my ultrabot. i moved the ultrasonic sensors read to a own thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants