Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding JS support to HTML parser #11

Closed
wants to merge 2 commits into from
Closed

Adding JS support to HTML parser #11

wants to merge 2 commits into from

Conversation

zerismo
Copy link

@zerismo zerismo commented Oct 16, 2016

#9

screenshot from 2016-10-16 23 23 20

@mbad0la
Copy link
Collaborator

mbad0la commented Oct 16, 2016

@karanchahal please review this as you reported this.

@karanchahal
Copy link
Member

Hey !
I'm sorry for the late response.This looks very good,slight issue though. When I put a for loop inside JavaScript, the '<' sign appears to be highlighted.
Ideally it shouldn't ,please fix this issue 💃

screenshot 26

#Thanks !

@mbad0la
Copy link
Collaborator

mbad0la commented Oct 17, 2016

@zerismo please follow-up on @karanchahal 's remarks.

@mbad0la
Copy link
Collaborator

mbad0la commented Oct 21, 2016

@zerismo your PR will be closed in a day to make way for #12
Please update if you want this merged.

@mbad0la mbad0la closed this Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerismo @mbad0la @karanchahal