improve greater than (or equal)

o1-labs · Oct 10, 2023 · 68a83ba · 68a83ba
1 parent c478ceb
commit 68a83ba
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/lib/field.ts b/src/lib/field.ts
@@ -748,8 +748,7 @@ class Field {
    * @return A {@link Bool} representing if this {@link Field} is greater than another "field-like" value.
    */
   greaterThan(y: Field | bigint | number | string) {
-    // TODO: this is less efficient than possible for equivalence with ml
-    return this.lessThanOrEqual(y).not();
+    return Field.from(y).lessThan(this);
   }
 
   /**
@@ -776,8 +775,7 @@ class Field {
    * @return A {@link Bool} representing if this {@link Field} is greater than or equal another "field-like" value.
    */
   greaterThanOrEqual(y: Field | bigint | number | string) {
-    // TODO: this is less efficient than possible for equivalence with ml
-    return this.lessThan(y).not();
+    return Field.from(y).lessThanOrEqual(this);
   }
 
   /**