-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign fields 4: Multiplication #1223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! Really appreciate all the descriptive comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job! I would nonetheless like to clarify a question about the circuit shape before accepting, to make sure all checks are getting in. I also have a question regarding division 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor suggestions and a question.
ForeignField.mul()
,ForeignField.inv()
,ForeignField.div()
ZkProgram.analyzeMethods()
to be nicer to read and to matchSmartContract.analyzeMethods()
(seems kinda unrelated; I did this to inspect number of rows of some ffmul methods. It's technically a breaking change but low impact)bindings: o1-labs/o1js-bindings#206
closes #1142