Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightnet namespace API updates. #1256

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Lightnet namespace API updates. #1256

merged 4 commits into from
Nov 21, 2023

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Nov 20, 2023

  • listAcquiredKeyPairs()

Related namespace API: #1167

@mitschabaude
Copy link
Collaborator

  • What does it mean if an account is "locked"?
  • Can we abstract this away from users? Is there any benefit to not always having all accounts unlocked?

@shimkiv
Copy link
Member Author

shimkiv commented Nov 20, 2023

  • What does it mean if an account is "locked"?
  • Can we abstract this away from users? Is there any benefit to not always having all accounts unlocked?

Turned out that accounts locking/unlocking capabilities on protocol level are more of the UX features than have any other implications. Removed corresponding API change of this PR since, as discussed, we don't want to expose it to the end users.

CHANGELOG.md Outdated Show resolved Hide resolved
@shimkiv shimkiv merged commit ac75360 into main Nov 21, 2023
13 checks passed
@shimkiv shimkiv deleted the lightnet-api-upd branch November 21, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants