Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keccak witness gen performance #1315

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Dec 13, 2023

Keccak witness generation is very slow.

This PR improves time for hashing 32 bytes by about 50% from ~18s to ~9s.

I identified the bottleneck that causes most of the remaining time and made an issue for it here: #1316

@mitschabaude mitschabaude requested a review from a team as a code owner December 13, 2023 15:44
run-debug Show resolved Hide resolved
Base automatically changed from feat/add-sha to main December 14, 2023 12:53
@mitschabaude mitschabaude merged commit 083c120 into main Dec 14, 2023
13 checks passed
@mitschabaude mitschabaude deleted the fix/bitwise-performance branch December 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants