Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash example #1346

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fix hash example #1346

merged 2 commits into from
Dec 23, 2023

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Dec 21, 2023 •
edited
Loading

Bugs in the example were reported on discord.

  • improper use of Bytes
  • Hash.hash() was throwing with this.initialState is not a function

Also fixes the type returned by Poseidon.update().

MartinMinkov
MartinMinkov approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🦖

@mitschabaude mitschabaude merged commit 015b0bf into main Dec 23, 2023
13 checks passed
@mitschabaude mitschabaude deleted the fix/hash-example branch December 23, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@ymekuria ymekuria ymekuria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @ymekuria @MartinMinkov