Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actual network genesis constants (genesisTimestamp, slotTime, accountCreationFee). #1367

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Use actual network genesis constants (genesisTimestamp, slotTime, accountCreationFee). #1367

merged 5 commits into from
Jan 21, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Jan 11, 2024

Closes #1366

@shimkiv shimkiv self-assigned this Jan 11, 2024
@shimkiv
Copy link
Member Author

shimkiv commented Jan 11, 2024

It probably won't work since getCachedGenesisConstants won't wait for promise to resolve...

@shimkiv shimkiv marked this pull request as draft January 11, 2024 18:55
@dfstio
Copy link

dfstio commented Jan 11, 2024

Is it possible to put genesis constants fetch logic into fetchLastBlock()?

@shimkiv shimkiv changed the title Use actual network genesis constants (timestamp). (WIP) Use actual network genesis constants (timestamp). Jan 12, 2024
@shimkiv shimkiv changed the title (WIP) Use actual network genesis constants (timestamp). Use actual network genesis constants (timestamp). Jan 13, 2024
@shimkiv shimkiv marked this pull request as ready for review January 13, 2024 12:38
@shimkiv shimkiv changed the title Use actual network genesis constants (timestamp). Use actual network genesis constants (timestamp, slotTime, accountCreationFee). Jan 13, 2024
@shimkiv shimkiv changed the title Use actual network genesis constants (timestamp, slotTime, accountCreationFee). Use actual network genesis constants (genesisTimestamp, slotTime, accountCreationFee). Jan 13, 2024
Trivo25
Trivo25 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a couple of nits!

src/examples/fetch_live.ts Outdated Show resolved Hide resolved
src/examples/fetch_live.ts Show resolved Hide resolved
src/lib/mina.ts Show resolved Hide resolved
@shimkiv shimkiv requested a review from Trivo25 January 20, 2024 12:11
Trivo25
Trivo25 approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the new API changes to the changelog, otherwise its good to go!

@shimkiv
Copy link
Member Author

shimkiv commented Jan 21, 2024

I think we should add the new API changes to the changelog, otherwise its good to go!

Added one, thank you.

@shimkiv
Copy link
Member Author

shimkiv commented Jan 21, 2024

@Trivo25 @mitschabaude if all is good now then I'll merge later today.

@shimkiv shimkiv merged commit 4b2f32a into main Jan 21, 2024
13 checks passed
@shimkiv shimkiv deleted the use-network-genesis-constants branch January 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

@ymekuria ymekuria Awaiting requested review from ymekuria

@MartinMinkov MartinMinkov Awaiting requested review from MartinMinkov

@mitschabaude mitschabaude Awaiting requested review from mitschabaude

Assignees

@shimkiv shimkiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

genesisTimestamp is hardcoded to a wrong date
4 participants
@shimkiv @dfstio @mitschabaude @Trivo25