Fix poseidon hash bottleneck in Mina submodule #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
force-pushed
the
perf/poseidon-hash-bottleneck
branch
from
ea96734 to
bb29f33
Compare
Trivo25
approved these changes
Jan 19, 2024
…ails for Poseidon hashing
…e to 'Unreleased' section This change is made to correctly reflect the status of the improvement, as it has not been released yet.
MartinMinkov
force-pushed
the
perf/poseidon-hash-bottleneck
branch
from
282138b to
88998ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mina: MinaProtocol/mina#14921
bindings: o1-labs/o1js-bindings#237
Summary
When performing a Poseidon hash, the Rust code responsible for performing the update has a bottleneck, primarily due to re-computing its internal parameters every time the function is invoked, as seen in the figure below.
It can be seen that
mina_poseidon::pasta::fp_kimchi::paramstakes nearly 50ms, where the total running time of the hash stack trace is 53ms. By using the static version of the params function, we only generate the params once and then reload them every time it's used.The results of the change can be seen in the figure below.
The profile shows that the params have not been generated this time, making the total running time 4ms.
This means we have a 13x speedup on Poseidon hashing 🎉