Improve performance by reverting Apple silicon workaround (root problem is fixed upstream) #1456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1337 ;)
Bindings PR: o1-labs/o1js-bindings#251
numCpus - 1
was faster a month ago, but when I tested today,numCores
was slightly faster).setNumberOfWorkers()
to allow developers to manually set the number of workers.I tested and everything worked well, prover time decrease of ~35% in browser, and ~46% in node. Compile time improvement is even more significant ~60%! (Tested on Apple M1 Pro 10-Core).
I wasn't exactly sure of the best way to implement the
setNumberOfWorkers()
function, and where everything should live/what it should be named. So I would appreciate any feedback on that kinda thing :)