Update proof-systems for safe lagrange-basis tracking #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I think the auxiliary changes might not be necessary with the TS version that o1js uses (there were significant improvements to type inference from conditionals in recent versions). |
|
Looks like these changes are good. I merged the proof systems PR and will get the mina, bindings, and o1js PRs merged this week. |
Trivo25
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1411.
This PR also includes some auxiliary changes in a separate commit, without which I could not make
maincompile.The bulk of the fix is here, forcing an API which forces us to generate a lagrange basis if one is not present, and as such removing all opportunity for the panics that halt the WASM interpreter.
o1js-bindings PR is up! o1-labs/o1js-bindings#307