Conditional recursion from within ZkProgram #1932
Open
+153
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
requested review from
hattyhattington17 and
querolita
and removed request for
a team
mitschabaude
changed the base branch from
feature/declare-proofs
to
feature/zkprogram-qol
45930
approved these changes
Jan 6, 2025
| @@ -56,6 +56,7 @@ import { emptyWitness } from '../provable/types/util.js'; | |||
| import { InferValue } from '../../bindings/lib/provable-generic.js'; | |||
| import { DeclaredProof, ZkProgramContext } from './zkprogram-context.js'; | |||
| import { mapObject, mapToObject, zip } from '../util/arrays.js'; | |||
| import { Bool } from '../provable/bool.js'; | |||
There was a problem hiding this comment.
Do we need to import Bool here?
There was a problem hiding this comment.
seems to be a left-over import, will fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1931
Adds another API
<methodName>.if()toExperimental.Recursivefor recursion within programs that is conditional on aBool. If the condition is false, we return a dummy proof that is not verified.For the first time ever, this enables us to implement a recursive function using recursive proofs in o1js! (Because the condition enables us to stop recursing eventually)
See a simple example of self-recursion at
hash-chain.ts