Voting Application B VM logic tests #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encingEvents"" This reverts commit 23fc757.
| @@ -1,17 +1,36 @@ | |||
| import { Experimental, Mina, AccountUpdate } from 'snarkyjs'; | |||
| import { | |||
There was a problem hiding this comment.
Should this test script be run as part of ./run-integration-tests.sh, so that voting tested in CI?
(And does this mean the voting/run.ts script doesn't need to run in CI anymore? Sorry I haven't really looked at either of these yet)
There was a problem hiding this comment.
run.ts sets the preconditions and parameters for the tests we want to run and then calls into test.ts to execute all the tests, so it's being run although maybe a bit confusing :D
bkase
requested changes
Oct 19, 2022
| /** | ||
| * Function used to upgrade a Membership contract with slightly modified methods, in order to manipulate the existing verification key | ||
| */ | ||
| /* export async function upgradeMembershipContract( |
There was a problem hiding this comment.
is this intentionally commented out? Can you delete it in that case? Are we testing this somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a wide range of different tests for the voting application. See the testing app b doc for reference
proofsEnabled: booleanflag when creating child account updates