-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified regex in removeJsonQuotes #419
Simplified regex in removeJsonQuotes #419
Conversation
Seems to work because now it reveals another issue (no stacktrace available): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! One more test and I'm happy :D
The web workers thing is a bummer, but we'll manage to work around that as well
@jdsteinhauser re: testing. Our Jest setup currently doesn't manage to build the whole project, so right now with Jest we can only test stuff that is exported from snarkyjs (all the other Jest test import We recently introduced a way to test internal stuff as well -- you can see it demonstrated in |
@jsteinhauser could you rebase the PR off of |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Oh my goodness, thanks for finishing this one out @Trivo25 ! |
Sorry it took so long :D |
Resolves Issue #415. I'm not satisfied with how I had to test it, since Jest wasn't happy with any way I tried to import
src/lib/fetch.[jt]s
. If an RFC is needed, I'll gladly write one but I was assuming this was small and straightforward enough to not require one.