Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename assertions to long form #681

Merged
merged 15 commits into from
Jan 18, 2023
Merged

rename assertions to long form #681

merged 15 commits into from
Jan 18, 2023

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Jan 9, 2023

  • replaces short forms of assertions with long form (lt -> lessThan..) and deprecates old ones
  • adjusts Field.lt in OCaml/bindings
  • fixed unknown error in berkeley live int test (fetching tx status)

MinaProtocol/mina#12494

closes #68
closes #26

gotta wait for a handful of other PRs before merging

@Trivo25 Trivo25 marked this pull request as ready for review January 11, 2023 09:35
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :D

src/snarky.d.ts Outdated
* ```
*
* This function can only be called inside a checked computation, like a
* SmartContract method, and causes it to fail if the assertion fails.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we fix that this "can only run in a checked computation"? Should remove those comments here and elsewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change still resides in develop , but yes we can already remove it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, well I hope we can merge it to main soon

@Trivo25 Trivo25 merged commit 7b2d719 into main Jan 18, 2023
@Trivo25 Trivo25 deleted the rename-assertions-fixed branch January 18, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add longer forms, lte-> lessThanOrEqual Change assertBoolean() > assertBool()
3 participants