-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename assertions to long form #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :D
src/snarky.d.ts
Outdated
* ``` | ||
* | ||
* This function can only be called inside a checked computation, like a | ||
* SmartContract method, and causes it to fail if the assertion fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we fix that this "can only run in a checked computation"? Should remove those comments here and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change still resides in develop
, but yes we can already remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, well I hope we can merge it to main soon
lt
->lessThan
..) and deprecates old onesMinaProtocol/mina#12494
closes #68
closes #26
gotta wait for a handful of other PRs before merging