-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support actions being dispatched from multiple AccountUpdates #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
force-pushed
the
fix/actions-hashing-fix
branch
from
March 21, 2023 00:45
4a053f9
to
3dc1fcf
Compare
Trivo25
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirmed it works with a contract that didn't work yesterday, good job!
mitschabaude
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the format from fetched actions to support multiple account updates with events in the same transaction.
Addresses #798
Tested
All listed zkApp accounts have successful transactions. To test, two transactions were issued with varying AccountUpdates and actions emitted. Then a
reduce
was given, with success on Berkeley.zkApp emitting single action in a single Account Update:
https://berkeley.minaexplorer.com/wallet/B62qp2R75kU97Sovki9987LNiDDcJkivRhPnpizvpzHWnhkXh3vqjt4
[ [ '1' ], [ '1' ] ]
-- getAction return value for two zkApp transactions with 1 Account Update eachzkApp emitting two actions in a single AccountUpdate:
https://berkeley.minaexplorer.com/wallet/B62qqNfTahass2YQfvgCs4L595gRnraadMGuK8bYsBK5VG2BdYEqhVw
[ [ '1', '1' ], [ '1', '1' ] ]
-- getAction return value for two zkApp transactions with 1 Account Update eachzkApp emitting single action with 3 Account Updates in a single transaction
https://berkeley.minaexplorer.com/wallet/B62qpYzTFqB7FcF79dyytvJ21jRUCxRespJVU2ZewV4CAEVAneop2BM
[ [ '1' ], [ '1' ], [ '1' ], [ '1' ], [ '1' ], [ '1' ] ]
-- getAction return value for two zkApp transactions with 3 Account Updates eachzkApp emitting two actions in 3 AccountUpdates in a single transaction:
https://berkeley.minaexplorer.com/wallet/B62qreiFZdVDNuXKVdujzJnqERfuxS5Wy4RQeNkJqhkjZCFibm25Qja
[ [ '1', '1' ], [ '1', '1' ], [ '1', '1' ], [ '1', '1' ], [ '1', '1' ], [ '1', '1' ] ]
-- getAction return value for two zkApp transactions with 3 Account Updates each