Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support actions being dispatched from multiple AccountUpdates #801

Merged
merged 12 commits into from
Mar 21, 2023

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Mar 20, 2023

Description:

Fixes the format from fetched actions to support multiple account updates with events in the same transaction.

Addresses #798

Tested

All listed zkApp accounts have successful transactions. To test, two transactions were issued with varying AccountUpdates and actions emitted. Then a reduce was given, with success on Berkeley.

@MartinMinkov MartinMinkov marked this pull request as ready for review March 20, 2023 18:20
@MartinMinkov MartinMinkov force-pushed the fix/actions-hashing-fix branch from 4a053f9 to 3dc1fcf Compare March 21, 2023 00:45
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed it works with a contract that didn't work yesterday, good job!

src/lib/fetch.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@MartinMinkov MartinMinkov merged commit 21de489 into main Mar 21, 2023
@MartinMinkov MartinMinkov deleted the fix/actions-hashing-fix branch March 21, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants