-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Field to JS #902
Merged
Merged
Move Field to JS #902
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
f3e42e2
Merge branch 'refactor/js-circuit' into refactor/field
mitschabaude 50c3f71
fixup
mitschabaude 625b04b
start on new field class
mitschabaude 864dbb1
simplify
mitschabaude 722ea52
fixup class redefinition
mitschabaude dae7cad
type internal field
mitschabaude 670af90
implement all field methods in the constant case
mitschabaude 3c7ff65
import Field from new file and fix some type errors
mitschabaude c1c0de4
temporarily switch back to ocaml FIeld
mitschabaude c7eb3a9
assertion messages
mitschabaude 3cc7b20
accept field like inputs
mitschabaude bef33b8
simpler & better field constructor
mitschabaude 2351566
some fixes
mitschabaude 5cf185b
also check if y is constant
mitschabaude abfe250
implement variable field ops with original field
mitschabaude 4a1729a
make all unit test work
mitschabaude 2e8b443
Merge branch 'main' into refactor/field
mitschabaude 28d23c3
low level snarky field
mitschabaude 9330630
start using lower-level snarky field ops
mitschabaude 72bd575
bump target bc TS messes up private class fields
mitschabaude b9f6b46
equals
mitschabaude 4f2dd19
lower level exists, improve internal API
mitschabaude 455f2ca
implement remaining Field API
mitschabaude 91a4cfe
copy over doccomments
mitschabaude f2a80a6
bindings
mitschabaude 17500a4
work around esbuild bug for web version
mitschabaude 331b548
minor
mitschabaude 70d740f
fix test expectations about assertEquals error
mitschabaude 3a063f7
fix constructor mismatch errors
mitschabaude 73e9302
move field class decl to top level to make ts output less weird
mitschabaude d81cfe7
fix voting test
mitschabaude 87f55e4
fix field unit tests
mitschabaude 8237a3a
unrelated
mitschabaude b0eadbf
match gates of empty contract
mitschabaude e3ae8fc
full constraint equivalence w/ old version
mitschabaude d7fb7bd
bindings
mitschabaude 51cef3a
Merge branch 'main' into refactor/field
mitschabaude 09e2567
revert some unnecessary changes
mitschabaude df66994
replace assertNonZero w/ more useful assertNotEquals
mitschabaude d60b958
minor
mitschabaude ca3a822
add tests
mitschabaude d55e889
Merge branch 'main' into refactor/field
mitschabaude 71308e7
fix field test
mitschabaude 365d71a
also test methods in provable code
mitschabaude 23900c6
break out lower level provable runners from provable.ts
mitschabaude cc2d5b9
error in compare, some cleanup
mitschabaude a56fa81
changelog
mitschabaude 2736eee
Merge branch 'main' into refactor/field
mitschabaude 4cab7c8
Merge branch 'main' into refactor/field
mitschabaude d220950
merge field tests
mitschabaude dae4a08
comment explaining vars vs constants
mitschabaude b58938a
move over new doccomments
mitschabaude 5a11762
doccomment
mitschabaude 8eebafe
address feedback
mitschabaude d6b7f5b
Merge branch 'main' into refactor/field
mitschabaude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule bindings
updated
from efebce to 371efb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes to errors required us to update some of the tests