Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Bool to JS #936

Merged
merged 72 commits into from
Jun 12, 2023
Merged

Move Bool to JS #936

merged 72 commits into from
Jun 12, 2023

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented May 31, 2023 •
edited
Loading

🔗 Bindings PR: o1-labs/o1js-bindings#27

@MartinMinkov MartinMinkov mentioned this pull request May 31, 2023
Merged
MartinMinkov and others added 27 commits June 1, 2023 13:16
@MartinMinkov
feat(snarky.d.ts): add bool API to support boolean operations in circ…
2492270 
…uits
@MartinMinkov
refactor(snarky.d.ts): move BoolVar type to bool.ts
5e19814
@MartinMinkov
feat(bool.ts): add isConstant, isBoolean, and refactor constructor
74883fe
@MartinMinkov
feat(bool.ts): add support for BoolVar type in constructor
a685130
@MartinMinkov
feat(bool.ts): implement not()
a95bea7
@MartinMinkov
feat(bool.ts): add isConstant function to check if a boolean or Bool …
f3b6e56 
…instance is constant
@MartinMinkov
feat(bool.ts): implement and()
db4f9b8
@MartinMinkov
feat(bool.ts): implement or()
1cca348
@MartinMinkov
feat(bool.ts): implement assertEquals()
24a127a
@MartinMinkov
feat(bool.ts): implement assertTrue()
6ed996d
@MartinMinkov
feat(bool.ts): implement assertFalse()
1faddde
@MartinMinkov
feat(bindings): update bindings
4f4bf50
@MartinMinkov
chore(bindings): update bindings
6c1d058
@MartinMinkov
feat(bool.ts): implement equals()
4c53337
@MartinMinkov
feat(bool.ts): add additional methods
ae836a8
@mitschabaude @MartinMinkov
scalar constructor
704e39f
@mitschabaude @MartinMinkov
to fields compressed
8eb7a09
@mitschabaude @MartinMinkov
constant scalar ops
523fd70
@mitschabaude @MartinMinkov
provable scalar
f26a8a9
@mitschabaude @MartinMinkov
from bits
56e7eee
@mitschabaude @MartinMinkov
fix api example
45f8d22
@mitschabaude @MartinMinkov
remaining methods
f4c232f
@mitschabaude @MartinMinkov
move back to ml-equivalent repr for Group.scale compatibility
14c97dc
@mitschabaude @MartinMinkov
fixup scalar representation
0f9420d
@mitschabaude @MartinMinkov
export new scalar everywhere
9a8c8c9
@mitschabaude @MartinMinkov
update tests
e2b74c5
@mitschabaude @MartinMinkov
remove new test
9595498
@MartinMinkov MartinMinkov changed the title WIP: Move Bool to JS Move Bool to JS Jun 7, 2023
@MartinMinkov MartinMinkov linked an issue Jun 7, 2023 that may be closed by this pull request
Move Bool class to JS #744
Closed
@mitschabaude mitschabaude mentioned this pull request Jun 8, 2023
Merged
@MartinMinkov MartinMinkov marked this pull request as ready for review June 8, 2023 20:40
mitschabaude
mitschabaude approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, let's merge it!

@mitschabaude mitschabaude merged commit bff6b34 into main Jun 12, 2023
@mitschabaude mitschabaude deleted the refactor/bool branch June 12, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Bool class to JS
2 participants
@MartinMinkov @mitschabaude