Clippy: be friendly with

kimchi/src/circuits/constraints.rs

@@ -322,7 +322,7 @@ impl<
             }
 
             // for public gates, only the left wire is toggled
-            if row < self.cs.public && gate.coeffs.get(0) != Some(&F::one()) {
+            if row < self.cs.public && gate.coeffs.first() != Some(&F::one()) {
                 return Err(GateError::IncorrectPublic(row));
             }
 

kimchi/src/circuits/polynomials/foreign_field_add/witness.rs

@@ -127,7 +127,7 @@ fn compute_ffadd_values<F: PrimeField>(
 /// opcode: true for addition, false for subtraction
 /// modulus: modulus of the foreign field
 pub fn create_chain<F: PrimeField>(
-    inputs: &Vec<BigUint>,
+    inputs: &[BigUint],
     opcodes: &[FFOps],
     modulus: BigUint,
 ) -> [Vec<F>; COLUMNS] {

kimchi/src/tests/foreign_field_add.rs

@@ -260,7 +260,7 @@ fn full_circuit<F: PrimeField + SquareRootField>(
 
 // Creates the witness with the public input for FFAdd containing the 1 value
 fn short_witness<F: PrimeField>(
-    inputs: &Vec<BigUint>,
+    inputs: &[BigUint],
     opcodes: &[FFOps],
     modulus: BigUint,
 ) -> [Vec<F>; COLUMNS] {
@@ -278,7 +278,7 @@ fn short_witness<F: PrimeField>(
 // opcode: true for addition, false for subtraction
 // modulus: modulus of the foreign field
 fn long_witness<F: PrimeField>(
-    inputs: &Vec<BigUint>,
+    inputs: &[BigUint],
     opcodes: &[FFOps],
     modulus: BigUint,
 ) -> [Vec<F>; COLUMNS] {
@@ -1401,7 +1401,7 @@ where
 
     // Compute addition witness
     let witness = short_witness(
-        &vec![left_input, right_input],
+        &[left_input, right_input],
         &[FFOps::Add],
         foreign_field_modulus.clone(),
     );
@@ -1476,7 +1476,7 @@ fn test_ffadd_finalization() {
         let left = modulus.clone() - BigUint::one();
         let right = modulus.clone() - BigUint::one();
         // create a chain of 1 addition
-        let add_witness = witness::create_chain::<Fp>(&vec![left, right], operation, modulus);
+        let add_witness = witness::create_chain::<Fp>(&[left, right], operation, modulus);
         for col in 0..COLUMNS {
             witness[col].extend(add_witness[col].iter());
         }
@@ -1548,7 +1548,7 @@ fn test_gate_invalid_foreign_field_modulus() {
 #[test]
 fn test_witness_max_foreign_field_modulus() {
     short_witness::<PallasField>(
-        &vec![BigUint::zero(), BigUint::zero()],
+        &[BigUint::zero(), BigUint::zero()],
         &[FFOps::Add],
         BigUint::max_foreign_field_modulus::<PallasField>(),
     );
@@ -1558,7 +1558,7 @@ fn test_witness_max_foreign_field_modulus() {
 #[should_panic]
 fn test_witness_invalid_foreign_field_modulus() {
     short_witness::<PallasField>(
-        &vec![BigUint::zero(), BigUint::zero()],
+        &[BigUint::zero(), BigUint::zero()],
         &[FFOps::Add],
         BigUint::max_foreign_field_modulus::<PallasField>() + BigUint::one(),
     );

msm/src/prover.rs

@@ -52,7 +52,7 @@ pub fn prove<
 >(
     domain: EvaluationDomains<G::ScalarField>,
     srs: &OpeningProof::SRS,
-    constraints: &Vec<MSMExpr<G::ScalarField>>,
+    constraints: &[MSMExpr<G::ScalarField>],
     inputs: ProofInputs<N, G, ID>,
     rng: &mut RNG,
 ) -> Result<Proof<N, G, OpeningProof>, ProverError>
@@ -205,7 +205,7 @@ where
         }
 
         let combined_expr =
-            Expr::combine_constraints(0..(constraints.len() as u32), constraints.clone());
+            Expr::combine_constraints(0..(constraints.len() as u32), constraints.to_owned());
 
         // An evaluation of our expression E(vec X) on witness columns
         // Every witness column w_i(X) is evaluated first at D1, so we get E(vec w_i(X)) = 0?

msm/src/verifier.rs

@@ -25,7 +25,7 @@ pub fn verify<
 >(
     domain: EvaluationDomains<G::ScalarField>,
     srs: &OpeningProof::SRS,
-    constraint_exprs: &Vec<MSMExpr<G::ScalarField>>,
+    constraint_exprs: &[MSMExpr<G::ScalarField>],
     proof: &Proof<N, G, OpeningProof>,
 ) -> bool {
     let Proof {
@@ -155,8 +155,10 @@ pub fn verify<
         zk_rows: 0,
     };
 
-    let combined_expr =
-        Expr::combine_constraints(0..(constraint_exprs.len() as u32), constraint_exprs.clone());
+    let combined_expr = Expr::combine_constraints(
+        0..(constraint_exprs.len() as u32),
+        constraint_exprs.to_owned(),
+    );
     let ft_eval0 = -PolishToken::evaluate(
         combined_expr.to_polish().as_slice(),
         domain.d1,

optimism/src/cannon.rs

@@ -285,6 +285,35 @@ impl Meta {
     }
 }
 
+pub const HINT_CLIENT_READ_FD: i32 = 3;
+pub const HINT_CLIENT_WRITE_FD: i32 = 4;
+pub const PREIMAGE_CLIENT_READ_FD: i32 = 5;
+pub const PREIMAGE_CLIENT_WRITE_FD: i32 = 6;
+
+pub struct Preimage(Vec<u8>);
+
+impl Preimage {
+    pub fn create(v: Vec<u8>) -> Self {
+        Preimage(v)
+    }
+
+    pub fn get(self) -> Vec<u8> {
+        self.0
+    }
+}
+
+pub struct Hint(Vec<u8>);
+
+impl Hint {
+    pub fn create(v: Vec<u8>) -> Self {
+        Hint(v)
+    }
+
+    pub fn get(self) -> Vec<u8> {
+        self.0
+    }
+}
+
 #[cfg(test)]
 mod tests {
 
@@ -456,32 +485,3 @@ mod tests {
         assert!(PreimageKey::from_str("0x01").is_err());
     }
 }
-
-pub const HINT_CLIENT_READ_FD: i32 = 3;
-pub const HINT_CLIENT_WRITE_FD: i32 = 4;
-pub const PREIMAGE_CLIENT_READ_FD: i32 = 5;
-pub const PREIMAGE_CLIENT_WRITE_FD: i32 = 6;
-
-pub struct Preimage(Vec<u8>);
-
-impl Preimage {
-    pub fn create(v: Vec<u8>) -> Self {
-        Preimage(v)
-    }
-
-    pub fn get(self) -> Vec<u8> {
-        self.0
-    }
-}
-
-pub struct Hint(Vec<u8>);
-
-impl Hint {
-    pub fn create(v: Vec<u8>) -> Self {
-        Hint(v)
-    }
-
-    pub fn get(self) -> Vec<u8> {
-        self.0
-    }
-}

poly-commitment/src/commitment.rs

@@ -507,7 +507,7 @@ pub fn combine_commitments<G: CommitmentCurve>(
 }
 
 pub fn combine_evaluations<G: CommitmentCurve>(
-    evaluations: &Vec<Evaluation<G>>,
+    evaluations: &[Evaluation<G>],
     polyscale: G::ScalarField,
 ) -> Vec<G::ScalarField> {
     let mut xi_i = G::ScalarField::one();

poly-commitment/src/pairing_proof.rs

@@ -296,10 +296,10 @@ impl<
     }
     pub fn verify(
         &self,
-        srs: &PairingSRS<Pair>,           // SRS
-        evaluations: &Vec<Evaluation<G>>, // commitments to the polynomials
-        polyscale: F,                     // scaling factor for polynoms
-        elm: &[F],                        // vector of evaluation points
+        srs: &PairingSRS<Pair>,        // SRS
+        evaluations: &[Evaluation<G>], // commitments to the polynomials
+        polyscale: F,                  // scaling factor for polynoms
+        elm: &[F],                     // vector of evaluation points
     ) -> bool {
         let poly_commitment = {
             let mut scalars: Vec<F> = Vec::new();

utils/src/field_helpers.rs

@@ -84,9 +84,7 @@ pub trait FieldHelpers<F> {
     where
         F: PrimeField,
     {
-        big.clone()
-            .into()
-            .map_err(|_| FieldHelpersError::DeserializeBytes)
+        F::from_biguint(big).map_err(|_| FieldHelpersError::DeserializeBytes)
     }
 
     /// Serialize to bytes