Skip to content

Commit

Permalink
Revert "Expression evaluation: evaluate over D2 instead of D1"
Browse files Browse the repository at this point in the history
This reverts commit be3d64e.
  • Loading branch information
volhovm committed Feb 29, 2024
1 parent 93909b3 commit bcd09ef
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions kimchi/src/circuits/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1844,13 +1844,8 @@ impl<F: FftField, Column: Copy + GenericColumn> Expr<F, Column> {
) -> Evaluations<F, D<F>> {
let d1_size = env.get_domain(Domain::D1).size;
let deg = self.degree(d1_size, env.get_constants().zk_rows);
// TODO @volhovm I'm not sure about this change, but otherwise we get a trivial polynomial.
// It never makes sense to evaluate expression over D1, since then we just get zero.
let d = if deg <= 2 * d1_size {
Domain::D2
//let d = Domain::D4;
// let d = if deg <= 2 * d1_size {
// Domain::D2
let d = if deg <= d1_size {
Domain::D1
} else if deg <= 4 * d1_size {
Domain::D4
} else if deg <= 8 * d1_size {
Expand Down

0 comments on commit bcd09ef

Please sign in to comment.