Skip to content

Commit

Permalink
Satisfy clippy
Browse files Browse the repository at this point in the history
  • Loading branch information
volhovm committed Feb 28, 2024
1 parent 479421b commit d172ca6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion msm/src/proof.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ impl<G: KimchiCurve> Witness<G> {
#[derive(Debug, Clone)]
pub struct ProofEvaluations<F> {
/// public input polynomials
pub(crate) public_evals: Option<PointEvaluations<F>>,
pub(crate) _public_evals: Option<PointEvaluations<F>>,
/// witness polynomials
pub(crate) witness_evals: WitnessColumns<PointEvaluations<F>>,
/// MVLookup argument
Expand Down
27 changes: 7 additions & 20 deletions msm/src/prover.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
use ark_ff::{Field, One, Zero};
use ark_poly::Evaluations;
use ark_poly::{
univariate::{DenseOrSparsePolynomial, DensePolynomial},
Polynomial, Radix2EvaluationDomain as D,
};
use ark_poly::{univariate::DensePolynomial, Polynomial, Radix2EvaluationDomain as D};
use rayon::iter::IntoParallelIterator;
use rayon::iter::ParallelIterator;

Expand Down Expand Up @@ -103,15 +100,11 @@ where

// Don't need to be absorbed. Already absorbed in mvlookup::prover::Env::create
// FIXME: remove clone
let mvlookup_comms = if let Some(ref lookup_env) = lookup_env {
Some(LookupProof {
m: lookup_env.lookup_counters_comm_d1.clone(),
h: lookup_env.lookup_terms_comms_d1.clone(),
sum: lookup_env.lookup_aggregation_comm_d1.clone(),
})
} else {
None
};
let mvlookup_comms = Option::map(lookup_env.as_ref(), |lookup_env| LookupProof {
m: lookup_env.lookup_counters_comm_d1.clone(),
h: lookup_env.lookup_terms_comms_d1.clone(),
sum: lookup_env.lookup_aggregation_comm_d1.clone(),
});

// -- end computing the running sum in lookup_aggregation
// -- End of MVLookup
Expand Down Expand Up @@ -220,12 +213,6 @@ where
let omega = domain.d1.group_gen; // index.cs.domain.d1.group_gen;
let zeta_omega = zeta * omega;

// We start the evaluations.
let zeta_chal = ScalarChallenge(fq_sponge.challenge());
let zeta = zeta_chal.to_field(endo_r);
let omega = domain.d1.group_gen;
let zeta_omega = zeta * omega;

// Evaluate the polynomials at zeta and zeta * omega -- Columns

let mvlookup_evals = {
Expand Down Expand Up @@ -389,7 +376,7 @@ where

let proof_evals: ProofEvaluations<G::ScalarField> = {
ProofEvaluations {
public_evals: None,
_public_evals: None,
witness_evals,
mvlookup_evals,
ft_eval1,
Expand Down

0 comments on commit d172ca6

Please sign in to comment.