Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the FFEC addition w/o ranges #1793

Closed
volhovm opened this issue Feb 5, 2024 · 0 comments
Closed

Implement the FFEC addition w/o ranges #1793

volhovm opened this issue Feb 5, 2024 · 0 comments
Assignees
@volhovm

Comments

@volhovm
Copy link
Member

volhovm commented Feb 5, 2024

By now we have additions and multiplications, so we can implement the EC addition formula.

Should be fairly easy compared to the previous steps. Maybe we will need to think about the infinity point -- most likely we can assume there are no infinity points in our protocol, which simplifies the task quite a bit.
@volhovm volhovm self-assigned this Feb 5, 2024
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Move existing FF circuits to ffa/ submodule
1858f3e
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
7604e11
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
3e2e78b
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
900ce63 
Squashme
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
af88c18
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Move existing FF circuits to ffa/ submodule
e271a33
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
55ee993
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
6b8b6c6
volhovm added a commit that referenced this issue Mar 4, 2024
@volhovm
[#1793] Split existing FFA constraints into witness and constraints f…
1c02154 
…iles
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Move existing FF circuits to ffa/ submodule
36c129d
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
93409c6
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
9cd9a88
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Split existing FFA constraints into witness and constraints f…
69121e9 
…iles
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Move existing FF circuits to ffa/ submodule
d94c422
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
2c04f85
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
4184873
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Split existing FFA constraints into witness and constraints f…
7c4d7f3 
…iles
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Move existing FF circuits to ffa/ submodule
c9d6ebd
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Rename MSMColumnIndexer to FFAColumnIndexer
055d4a1
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Get rid of unnecessary WitnessColumnIndexer
1bd3d0b
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Split existing FFA constraints into witness and constraints f…
68ed4c8 
…iles
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Move main.rs to ffa/
9a95bce
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Add minimal FFAInterpreterEnv
0607416
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Start implementing FFAInterpreterEnv for FFA WitnessBuilder
e543598
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Add minimal FFAInterpreterEnv
fec07b2
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Start implementing FFAInterpreterEnv for FFA WitnessBuilder
3ce8795
volhovm added a commit that referenced this issue Mar 5, 2024
@volhovm
[#1793] Start implementing FFAInterpreterEnv for FFA WitnessBuilder
42382dd
volhovm added a commit that referenced this issue Mar 6, 2024
@volhovm
[#1793] FFA: Add get_column method to interpreter/witness
615474b
volhovm added a commit that referenced this issue Mar 6, 2024
@volhovm
[#1793] MSM FFA: Rewrite existing circuits to use interpreter
f8e8f5b
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Pack carries in 6 small limbs
1b4834b
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add range check interface + witness assertions
2fd822f
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add in-field range check
64ae1b3
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add full prover-verifier ECADD test
21ed791
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Another comment on range checks
2993010
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Fix the total number of columns
4a84a40
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Remove outdated comments
47eb077
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Implement EC ADD circuit + witness generation
413cdcd 
Squash
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add comment on carry ranges
fd3f457
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add script computing/checking carry ranges
32f8e99
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Improve range estimates
2988449
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Update range computation script
de90faf
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Pack carries more efficiently, for now w/o range checks
f1152c1
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Comment on absolutely maximum carry values
f589a59
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Update carry computation scirpt to output max values
a2aac25
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Pack carries in 6 small limbs
7dc8fb4
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add range check interface + witness assertions
a498f2a
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add in-field range check
a2fe4c3
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Add full prover-verifier ECADD test
28222ac
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Another comment on range checks
5b1631d
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Fix the total number of columns
0b6e78e
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Remove outdated comments
d5c4820
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Fix ff_higest range check
605ae08
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Outline column structure for FFMul in serialization
0ec00b4
volhovm added a commit that referenced this issue Mar 21, 2024
@volhovm
[#1793] Outline column structure for FFMul in serialization
f409404
volhovm added a commit that referenced this issue Mar 22, 2024
@volhovm
[#1793] Add documentation on FF EC addition
308f945
volhovm added a commit that referenced this issue Mar 22, 2024
@volhovm
[#1793] WIP type-based gadget composition
d690db3
volhovm added a commit that referenced this issue Mar 28, 2024
@volhovm
[#1793] Outline column structure for FFMul in serialization
4ab1b42
volhovm added a commit that referenced this issue Mar 28, 2024
@volhovm
[#1793] Outline column structure for FFMul in serialization
7d7b087
@volhovm volhovm closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volhovm volhovm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@volhovm