Start dummy implementation of InterpreterEnv for Env in witness #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/add-some-methods-in-env-witness
branch
from
f9d19e3 to
e061d34
Compare
volhovm
approved these changes
Feb 28, 2024
| impl<const N: usize, Fp: Field> InterpreterEnv for Env<N, Fp> { | ||
| type Position = Column; | ||
|
|
||
| // FIXME: is u128 ok? I think so, we only have 15 bits, 88 bits and 4 bits |
There was a problem hiding this comment.
I feel it should be OK, indeed all our limbs are strictly smaller... And whatever FFMul we do it'll be on 15 bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.