Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial flake for installing build dependencies for proof-systems #2509

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Fizzixnerd
Copy link
Contributor

@Fizzixnerd Fizzixnerd commented Aug 28, 2024

This is the start of a very simple flake.

In scope for this version of the flake:

  1. nix develop . will open a dev shell with everything you need to develop on various parts of proof-systems in scope (caveat about rust and ocaml toolchain version in next point).
  2. You must still use rustup to manage your rust toolchains.
  3. You must still use opam to manage your ocaml toolchains.

Out of scope for this version of the flake:

  1. Distributed caching -- only if the others in this list come.
  2. Actually building things using nix -- likely to come.

@Fizzixnerd Fizzixnerd added the enhancement New feature or request label Aug 28, 2024
@Fizzixnerd Fizzixnerd requested a review from georgeee August 28, 2024 21:38
@Fizzixnerd Fizzixnerd self-assigned this Aug 28, 2024
@Fizzixnerd Fizzixnerd force-pushed the fizzixnerd/initial-flake branch from aea3d95 to 94a0a9b Compare August 28, 2024 22:08
@Fizzixnerd Fizzixnerd marked this pull request as ready for review August 28, 2024 22:15
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a continuous check in the CI that it works, and the code can be built, please?

@Fizzixnerd
Copy link
Contributor Author

Can we have a continuous check in the CI that it works, and the code can be built, please?

Absolutely. I have tested

cargo build and that succeeds. What other checks would you like? My understanding is there is go and ocaml code somewhere in this repo.

@dannywillems
Copy link
Member

Can we have a continuous check in the CI that it works, and the code can be built, please?

Absolutely. I have tested

cargo build and that succeeds. What other checks would you like? My understanding is there is go and ocaml code somewhere in this repo.

Would it be worth, even if the nix config is simple, to check in the CI that it works? By running, for instance, cargo build in the nix environment? IIRC, we do that in the Mina repository.

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it is pretty simple. As a non-nix user, I simply tried the commands in the README.
Feel free to merge.

@Fizzixnerd
Copy link
Contributor Author

Can we have a continuous check in the CI that it works, and the code can be built, please?

Absolutely. I have tested
cargo build and that succeeds. What other checks would you like? My understanding is there is go and ocaml code somewhere in this repo.

Would it be worth, even if the nix config is simple, to check in the CI that it works? By running, for instance, cargo build in the nix environment? IIRC, we do that in the Mina repository.

I will make an issue so I don't forget to.

@Fizzixnerd Fizzixnerd merged commit e89f27c into master Aug 29, 2024
7 checks passed
@Fizzixnerd Fizzixnerd deleted the fizzixnerd/initial-flake branch August 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants