Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding and proving for smaller programs #2956

Open
wants to merge 1 commit into
base: dw/no-op
Choose a base branch
from

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 17, 2025

Builds on #2910 and uses the no-op selector to do the padding.

You can run against any test mips program using

 RUST_LOG=debug ./o1vm/test-mips-program-prover.sh o1vm/resources/programs/mips/bin/nor srs/test_vesta.srs

where you can replace nor with any test mips program (except the oracle programs, see #2944) . I didn't add this to CI, but we can if we want.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 3.70370% with 78 lines in your changes missing coverage. Please review.

Project coverage is 76.54%. Comparing base (54a9e0c) to head (3c77506).

Files with missing lines Patch % Lines
o1vm/src/pickles/main.rs 0.00% 72 Missing ⚠️
o1vm/src/interpreters/mips/witness.rs 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dw/no-op    #2956      +/-   ##
============================================
- Coverage     76.60%   76.54%   -0.06%     
============================================
  Files           255      255              
  Lines         61066    61112      +46     
============================================
  Hits          46781    46781              
- Misses        14285    14331      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall marked this pull request as ready for review January 18, 2025 01:36
@martyall martyall requested a review from dannywillems January 18, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant