-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move long running o1vm test to nightly, run tests for small programs #3010
base: master
Are you sure you want to change the base?
Conversation
e1b82cc
to
9c81d15
Compare
9c81d15
to
32ecf44
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3010 +/- ##
==========================================
+ Coverage 76.83% 76.87% +0.03%
==========================================
Files 262 262
Lines 62028 62114 +86
==========================================
+ Hits 47662 47750 +88
+ Misses 14366 14364 -2 ☔ View full report in Codecov by Sentry. |
Yes, and we will need to load a previous state. Discussion on Slack:
|
! -name "oracle*" \ | ||
! -name "exit_group" \ | ||
! -name "mul" | \ | ||
xargs -I {} env RUST_LOG=debug ./o1vm/test-mips-program-prover.sh {} ./srs/test_vesta.srs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed online, I would parallelise it, using an equivalent strategy than in o1js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refusing for now as it takes > 60m "O1VM MIPS Prover CI / Run o1vm prover on all mips tests (1.74) (pull_request) Successful in 65m" to run the new job. Suggested to parallelize.
I'm pretty sure I'm using the
on.schedule
correctly, but I'm unsure how/when it reports to the current PR. The main concern would be that get notified of a failure in the right placebad news: it takes about the same amount of time as the current job running for 3M instructions (if I understand the current job's
--stop-at =3000000
arg). Do I remember that we were going to bump this to use the preimage oracle? In that case maybe its worth it.I don't think running in parallel will help here as even one program is utilizing all cores on my machine (there are a fair number of parallel commitments being computed)